Windows support in CI #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
|
@ok-nick What could explain the failure here? This build is now using the just-released libcec-sys with windows support |
|
You have to run this action to setup the vs environment. |
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
|
Tbh we may be able to hard code it to run the 2019 |
|
Recent CI error looks due to using an old |
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
|
Latest run failed with |
|
What's different from the |
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
|
Diff in latest commit (I expect same result from CI run). I do not see any relevant differences when it comes to Windows :o ❯ diff -b --color libcec-sys/.github/workflows/ci.yml cec-rs/.github/workflows/ci.yml
2d1
< workflow_dispatch:
13c12
< name: Test Suite ${{ matrix.job.target }} (${{ matrix.job.libcec }} pkg-config=${{ matrix.job.pkg-config || false }})
---
> name: Test Suite ${{ matrix.job.target }} (${{ matrix.job.libcec }})
71c70
< use-cross: false # Not run in cross so that EXPECTED_LIBCEC_VERSION_MAJOR shows inside the test
---
> use-cross: true
91,114d89
< #
< # libcec discovery without pkg config
< # We set LD_LIBRARY_PATH and C_INCLUDE_PATH for compiler to find the preinstalled libcec
< #
< - os: ubuntu-22.04
< target: x86_64-unknown-linux-gnu
< use-cross: false # Important that we do not run cross so package install shows up
< libcec: "libcec4"
< libcec-dev: "libcec-dev=4*"
< pkg-config: false
< expected_libcec_abi: 4
< additional_env:
< LD_LIBRARY_PATH: "/usr/lib/x86_64-linux-gnu/"
< C_INCLUDE_PATH: "/usr/include/libcec/"
< - os: ubuntu-22.04
< target: x86_64-unknown-linux-gnu
< use-cross: false # Important that we do not run cross so package install shows up
< libcec: "libcec6"
< libcec-dev: "libcec-dev=6*"
< pkg-config: false
< expected_libcec_abi: 6
< additional_env:
< LD_LIBRARY_PATH: "/usr/lib/x86_64-linux-gnu/"
< C_INCLUDE_PATH: "/usr/include/libcec/"
118,122d92
< - name: Checkout libcec-sys submodules
< run: git -c "url.https://github.com/.insteadOf=git@github.com:" submodule update --init --recursive
< - name: Apt-get update
< if: runner.os == 'Linux'
< run: sudo apt-get update -yq
169a140
> uses: actions-rs/cargo@v1
172,174d142
< LD_LIBRARY_PATH: ${{ matrix.job.additional_env.LD_LIBRARY_PATH }}
< C_INCLUDE_PATH: ${{ matrix.job.additional_env.C_INCLUDE_PATH }}
< uses: actions-rs/cargo@v1
187,200d154
< - name: Checkout submodules
< shell: bash
< # basically git submodule update --init --recursive but replacing git@github.com with https
< # for anonymous checkout
< run: |
< git submodule update --init
< git submodule foreach --recursive '
< echo "pwd: $(pwd)" ; \
< if [ -f .gitmodules ]; then \
< ( sed -i "s/git@github.com:/https:\/\/github.com\//" .gitmodules \
< && git submodule sync --recursive ) ; \
< fi ; \
< git submodule update --init \
< ;'
220,233d173
< - name: Checkout submodules
< shell: bash
< # basically git submodule update --init --recursive but replacing git@github.com with https
< # for anonymous checkout
< run: |
< git submodule update --init
< git submodule foreach --recursive '
< echo "pwd: $(pwd)" ; \
< if [ -f .gitmodules ]; then \
< ( sed -i "s/git@github.com:/https:\/\/github.com\//" .gitmodules \
< && git submodule sync --recursive ) ; \
< fi ; \
< git submodule update --init \
< ;'
247a188,217
>
> coverage:
> name: Code coverage
> runs-on: ubuntu-22.04
> steps:
> - name: Checkout repository
> uses: actions/checkout@v2
> - name: Update apt
> run: sudo apt-get update
> - name: Install dependencies for build and coverage
> run: sudo apt-get install libudev-dev libcec6 libcec-dev pkg-config libp8-platform-dev
> - name: Install stable toolchain
> uses: actions-rs/toolchain@v1
> with:
> toolchain: stable
> profile: minimal
> override: true
> - name: Run cargo-tarpaulin
> uses: actions-rs/tarpaulin@v0.1.3
> with:
> args: "--ignore-tests --out Lcov"
> env:
> EXPECTED_LIBCEC_VERSION_MAJOR: 6
> - name: Upload to Coveralls
> # upload only if push
> if: ${{ github.event_name == 'push' }}
> uses: coverallsapp/github-action@master
> with:
> github-token: ${{ secrets.GITHUB_TOKEN }}
> path-to-lcov: "./lcov.info"
|
|
Can this issue be reproduced locally on windows box? |
|
I compiled it straight from the |
Closed
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
|
Committed just with the dependency bump, but windows CI disabled. #27 created to resolve the CI issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25
Signed-off-by: Sami Salonen ssalonen@gmail.com