Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Use PEP 508 version markers. #13

Merged
merged 1 commit into from
Jan 25, 2018
Merged

BLD: Use PEP 508 version markers. #13

merged 1 commit into from
Jan 25, 2018

Conversation

ehebert
Copy link
Contributor

@ehebert ehebert commented Jan 25, 2018

So that environment tooling, e.g. pipenv can use the python version markers
when determining dependencies.

BLD: Use PEP 508 version markers.
a6c72fb 
So that environment tooling, e.g. `pipenv` can use the python version markers
when determining dependencies.
@ehebert
Copy link
Contributor Author

ehebert commented Jan 25, 2018

I checked the markers by running tox and looking at which packages where installed for each version.

Here are the lines for each version:

py27 installed: funcsigs==1.0.2,pkg-resources==0.0.0,python-interface==1.4.0,six==1.11.0,typing==3.6.4
py34 installed: pkg-resources==0.0.0,python-interface==1.4.0,six==1.11.0,typing==3.6.4
py35 installed: pkg-resources==0.0.0,python-interface==1.4.0,six==1.11.0

@ssanderson
Copy link
Owner

LGTM

@ssanderson ssanderson merged commit da10b6b into ssanderson:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehebert @ssanderson