scuttle-cleanup #1
Conversation
also clean up some of the sodium-native handling. I have the strong feeling those also need the app/ path
|
@cryptix I'm just discovering your work, and also looking at extending it with some other files I was finding I needed when I ran this AppImage on a fresh kubuntu 18.10 install |
| ], | ||
| "extraFiles": [ | ||
| "app/node_modules/sodium-native/prebuilds/${os}-${arch}/electron-57.node", | ||
| "app/node_modules/sodium-native/prebuilds/${os}-${arch}/libsodium.*", |
There was a problem hiding this comment.
can you help me get my head around why it's safe to move these prebuilds from files to extraFiles @cryptix ?
What's the difference ... I read the docs and found it kinda opaque
package.json
Outdated
| "asarUnpack": [ | ||
| "node_modules/sodium-native/prebuilds" | ||
| ], | ||
| "npmSkipBuildFromSource": true, |
There was a problem hiding this comment.
why did you remove these two options @cryptix ?
is it because asarUnpack by default hits the node_modules?
I would have thought skipBuiild... would be good because it gets you prebuilts?
There was a problem hiding this comment.
I've added these back in for the moment
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hey @christianbundy this stalebot is closing something I want open.
Can you change the setting to never close PRs on all repos? At most it
should poke it imo
…On Wed, 9 Jan 2019, 14:28 stale[bot], ***@***.***> wrote:
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACitnvpbicf9NTPXHO6dmAfNCljsUzwxks5vBUXEgaJpZM4YT6FS>
.
|
Cryptix said