Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go side of sign-in with ssb #90

Merged
merged 19 commits into from Mar 26, 2021
Merged

go side of sign-in with ssb #90

merged 19 commits into from Mar 26, 2021

Conversation

cryptix
Copy link
Member

@cryptix cryptix commented Mar 17, 2021

This is now based on #91, which should be merged first! Done!

  • /auth/withssb/login endpoint (url subject to change to conform with the spec)
  • do the database lookups (is a member)
  • verify the challenge response
  • test (with mocked rpc client)
  • hand out a cookie, just like fallback auth
  • server-initiated SSE dance
  • tests for server-initiated
  • rate limit to not spam client devices

fixes #11

@cryptix cryptix added the Go golang related stuff label Mar 17, 2021
@cryptix cryptix self-assigned this Mar 17, 2021
@cryptix cryptix added this to In progress in Sign-In with SSB via automation Mar 17, 2021
@cryptix cryptix mentioned this pull request Mar 19, 2021
14 tasks
@cryptix cryptix changed the base branch from master to schema-overhaul March 22, 2021 13:10
Base automatically changed from schema-overhaul to master March 23, 2021 07:08
@cryptix cryptix force-pushed the sign-in-with-ssb branch 2 times, most recently from 5bdc985 to 58a6f13 Compare March 24, 2021 08:35
@cryptix cryptix marked this pull request as ready for review March 24, 2021 08:35
@staltz
Copy link
Member

staltz commented Mar 24, 2021

I think I saw a couple "challange" lying around waiting to be massaged. 😺

web/assets/login-events.js Outdated Show resolved Hide resolved
* sketch session store
* use session store and unify authentication handling
* sketch muxrpc handlers
* fill in sid and sc
* fix logout
* cascade member removal
* fix links
* trim suffix from signature
* fix /sse/login link
* fix sse links and filenames
* fix logout
* fix typos
* fix test compilation
* fix bridge test
* correct alias url test
* add some comments
* fix potentiall "can't send" deadlock on bridge

some documentation and license headers
cryptix and others added 9 commits March 26, 2021 13:45
* redirect and save the cookie
* supress a warning and redirect immediatly
* add test for sse login
* add test for invalid solution
these timeouts affect server-sent events, too and interfer with sign-in with ssb.
web/assets/login-events.js Outdated Show resolved Hide resolved
web/assets/login-events.js Outdated Show resolved Hide resolved
web/assets/login-events.js Outdated Show resolved Hide resolved
web/assets/login-events.js Outdated Show resolved Hide resolved
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few optional suggestions, but good to merge :)

Sign-In with SSB automation moved this from In progress to Reviewer approved Mar 26, 2021
cryptix and others added 3 commits March 26, 2021 14:49
change variable declaration in login-events.js to const

Co-authored-by: André Staltz <andre@staltz.com>
* fix auth test
* fix notices test and parallelize
* cleanup unused input lookup
@cryptix cryptix merged commit 8821b99 into master Mar 26, 2021
Sign-In with SSB automation moved this from Reviewer approved to Done Mar 26, 2021
@cryptix cryptix deleted the sign-in-with-ssb branch March 26, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go golang related stuff
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Sign-in with SSB RPC dance
2 participants