Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoding and decoding of SSB URIs #9

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Conversation

mycognosist
Copy link
Member

@mycognosist mycognosist commented Sep 30, 2021

encode_uri() is not as elegant as I'd like but I'll loop back to it and refactor at some point.

@mycognosist mycognosist marked this pull request as ready for review October 1, 2021 13:19
src/data.rs Outdated Show resolved Hide resolved
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a thorough check, but I did take 10min to look through everything and it seems correct. :)

@mycognosist
Copy link
Member Author

@staltz

Thanks for your time and effort! 🙏🏻 🖤

I imagine I'll find a few bugs and room for improvement when I plug this into ssb-bendy-butt-rs.

@mycognosist mycognosist merged commit 92279bd into main Oct 4, 2021
@mycognosist mycognosist deleted the ssb_uri_support branch October 4, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants