New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script with a bunch of common queries #136
Conversation
Benchmark results
|
Could we merge this PR only when it's running against ssb-fixtures? This way we can objectively compare numbers across computers, and we don't need to depend on personal data (and their msg.keys), also making it better for other future contributors to run them. |
Yes very good idea. Was mostly interested in getting in some good queries that are used a lot in apps. |
Or actually, how about folding these into the benchmark/index.js? After all, the goal of these scripts is to check the perf. Then it's easier, just add new tests with these queries |
Agree, that's what I meant with the: "Might be good to run in the CI thingy" :-) I'm using this now mostly to test the optimization for prefixes. Once that is done I'll make a proper PR. This was mostly meant as an open invitation if you have any queries from your threads testing but you can of course always add them afterwards :) |
Benchmark results
|
0650a72
to
27be5cd
Compare
Benchmark results
|
benchmark/index.js
Outdated
|
||
'votes one': [and(votesFor(KEY1))], | ||
|
||
'votes again': [and(votesFor(KEY1))], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arj03 see above, can we delete one of these? Running it three times doesn't seem necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@arj03 I pushed some commits that move these queries into benchmark/index.js |
Benchmark results
|
The idea with the second run is that we test not having to load the index from disc. So it needs to be a another key otherwise we will test your weakmap cache instead. |
Other than that it's really good to see these queries here in the CI |
Alright, LGTM. How about you review and merge? (note that perf.js was deleted) |
Benchmark results
|
Benchmark results
|
I noticed that I didn't have a very good idea of how common queries are running. This gives us a better idea. Might be good to run in the CI thingy. But for now I'll just dump them here.
Output