Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert KVT to value for benchmarks #8

Merged
merged 2 commits into from Jun 18, 2021
Merged

Convert KVT to value for benchmarks #8

merged 2 commits into from Jun 18, 2021

Conversation

mycognosist
Copy link
Member

Convert each message from a KVT to a value when performing benchmarks. Also replace appendKVT with append for JS ssb-validate equivalent benchmarks.

@mycognosist mycognosist added the bug Something isn't working label Jun 17, 2021
@mycognosist mycognosist requested a review from staltz June 18, 2021 11:41
staltz
staltz reviewed Jun 18, 2021
View reviewed changes
test/perf.js Outdated Show resolved Hide resolved
staltz
staltz reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green everywhere!

@mycognosist mycognosist merged commit 10f669a into main Jun 18, 2021
@mycognosist mycognosist deleted the fix_benchmarks branch June 18, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mycognosist @staltz