Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Electron workaround still necessary? #20

Closed
christianbundy opened this issue Sep 9, 2020 · 2 comments
Closed

Is Electron workaround still necessary? #20

christianbundy opened this issue Sep 9, 2020 · 2 comments

Comments

@christianbundy
Copy link
Contributor

There's an Electron workaround in index.js that was added in July 2016, which was before Electron 1.3 was released (Chrome 52, Node 6). Four years later Electron is on version 10.11, and I've tested all the way back to Electron 7 and I can't find the problem. Does anyone have more context on what platform the problem was happening on? The only context I have is 50dbe3b, but that doesn't tell us much.

If the underlying problem is gone, I'd love to remove the workaround, but I thought I should make an issue before making a PR.

@arj03
Copy link
Member

arj03 commented Sep 10, 2020

I don't see why that should be there still. Lets Get It Removed :-)

@austinfrey
Copy link
Contributor

@christianbundy I did some tests going all the way back to electron v1. Things break around v3 but not due to the detached methods I don't think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants