Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash replicating #15

Closed
arj03 opened this issue Apr 12, 2018 · 5 comments
Closed

Crash replicating #15

arj03 opened this issue Apr 12, 2018 · 5 comments

Comments

@arj03
Copy link
Member

arj03 commented Apr 12, 2018

/home/chrx/dev/scuttlebot/node_modules/epidemic-broadcast-trees/events.js:415
if(peer.clock[feed_id] || 0 > state.clock[feed_id] || 0) {
^
TypeError: Cannot read property '@f/6sQ6d2CMxRUhLpspgGIulDxDCwYD7DzFzPNr7u5AU=.ed25519' of null
at /home/chrx/dev/scuttlebot/node_modules/epidemic-broadcast-trees/events.js:415:20
at eachFrom (/home/chrx/dev/scuttlebot/node_modules/epidemic-broadcast-trees/events.js:75:8)
at Object.exports.timeout (/home/chrx/dev/scuttlebot/node_modules/epidemic-broadcast-trees/events.js:413:5)
at Timeout._onTimeout (/home/chrx/dev/scuttlebot/node_modules/epidemic-broadcast-trees/index.js:94:25)
at ontimeout (timers.js:478:11)
at Timer.unrefdHandle (timers.js:598:5)

@dominictarr
Copy link
Contributor

was the error message really missing the key?
TypeError: Cannot read property '=.ed25519' of null or did you remove that for privacy?
because that would be two weird things happening

@dominictarr
Copy link
Contributor

it looks like it's hit the timeout before the clock has loaded... (which could happen) but that someone requested an invalid feed id worries me more.

@dominictarr
Copy link
Contributor

should be fixed in 6.2.2

@dominictarr
Copy link
Contributor

also i added better validation so if weird feed ids happen they will be ignored. which is fixed in ssb-ebt@5.1.5

@arj03
Copy link
Member Author

arj03 commented Apr 16, 2018

I didn't remove anything, that was the error I got. I think I only saw it once and then restarted and didn't see it again, just wanted to report it as its a crasher. Thanks for fixing!

@arj03 arj03 closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants