Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunnel.ping confuses tunnel.* namepace for rooms client #231

Open
decentral1se opened this issue Nov 25, 2022 · 2 comments
Open

tunnel.ping confuses tunnel.* namepace for rooms client #231

decentral1se opened this issue Nov 25, 2022 · 2 comments
Labels
question Further information is requested

Comments

@decentral1se
Copy link
Member

Tracking resolution for #221 (comment)

@decentral1se decentral1se added the bug Something isn't working label Nov 25, 2022
@KyleMaas
Copy link
Contributor

I honestly don't know. isRoom on a pub? But that's not really my main point. The logic of isRoom on go-ssb right now is not confirming if go-ssb itself is a room or not, it is forwarding a request on to a room. But the logic of ping on go-ssb doesn't forward the request on to a room, it just responds a ping from the pub. The semantics of the calls are very different. I'm really not familiar with MUXRPC but this seems confusing and not intuitive. So again, maybe we just need docs?

That kind of architectural question of how it should be is above my pay grade to answer. It does make some sense to me to have tunnel.ping ping through to the final endpoint rather than be returned by the intermediate tunnel broker. But the one concern I have is that the current behavior is, as far as I can tell, consistent with the behavior of the JavaScript ssb-tunnel. If the decision is made that that doesn't make sense, then it should probably be changed in both places so the Go and JS versions are consistent and compatible and the client doesn't have to think about whether it's talking to a Go-based pub/room or a JS-based pub/room and manage its expectations of the ping behavior accordingly.

@decentral1se decentral1se added question Further information is requested and removed bug Something isn't working labels Nov 30, 2022
@decentral1se
Copy link
Member Author

Hoping the docs work goes down in #238 helps create visbility for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants