Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double follow on redeeming an invite by an already followed feed #59

Open
irisdelaluna opened this issue Jun 26, 2020 · 3 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@irisdelaluna
Copy link
Contributor

To reproduce:

  1. create new identity;
  2. start server fresh;
  3. follow feed A;
  4. generate an invite with sbotcli call invite.create;
  5. send that invite to the owner of feed A, let it be redeemed.
  6. see two follow messages on your feed, feed A is being followed twice.
@cryptix
Copy link
Member

cryptix commented Jun 26, 2020

Which client used the invite in this case?

@irisdelaluna
Copy link
Contributor Author

@cryptix Patchwork

@cryptix
Copy link
Member

cryptix commented Jul 2, 2020

I see, okay. I think there is retry logic if something goes wrong in patchwork. Ideally there should be more e2e scenarios in the tests folder of this implementation. Testing against ssb-server would be enough, no need to boot patchwork.

To stop the double follows you could add a graph lookup here.

@cryptix cryptix added bug Something isn't working help wanted Extra attention is needed labels Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Development

No branches or pull requests

2 participants