Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tabs.js just another screen_view #52

Closed
dominictarr opened this issue Jul 21, 2016 · 2 comments
Closed

make tabs.js just another screen_view #52

dominictarr opened this issue Jul 21, 2016 · 2 comments

Comments

@dominictarr
Copy link
Contributor

I think we should treat tabs as just another screen view. and use the # in the browser as a way to set UI state, that way, we can link to {bootstrap_server}#{invite_code}#{welcome_message} and you'll be able to send someone that code, get them in the network, and then lead them to an welcome message from you explaining what you have just gotten them into.

It also means the UI is highly composable, which is surely a good thing. This does also means we'll need to refactor some stuff that assumes tabs is the top level and a singleton.

@dominictarr
Copy link
Contributor Author

i.e. how state is persisted, and how keyboard events are persisted.

@stale
Copy link

stale bot commented Nov 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2018
@stale stale bot closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants