Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new members to all tip epochs, and make sure that re-adding is allowed #36

Open
Powersource opened this issue Oct 13, 2023 · 1 comment

Comments

@Powersource
Copy link
Contributor

We had a discussion on signal and i wrote this:

https://github.com/ssbc/ssb-group-exclusion-spec#49-adding-new-members

Idk if the spec describes what we have in code that well

The code publishes one add per epoch tip

Also "The "correct membership" for a particular epoch is calculated as the union of all declared members in all epochs, minus the union of all excluded members in any epoch up till that epoch." sounds wrong, that disallows re-adding, which is something the module supports

@Powersource
Copy link
Contributor Author

where this was implemented ssbc/ssb-tribes2#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant