Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateLookup has nasty edge cases #91

Open
mixmix opened this issue Oct 6, 2022 · 0 comments
Open

updateLookup has nasty edge cases #91

mixmix opened this issue Oct 6, 2022 · 0 comments

Comments

@mixmix
Copy link
Member

mixmix commented Oct 6, 2022

in lookup.js

  function updateLookup(msg) {
    const { type, subfeed, metafeed } = msg.value.content

    // Update roots
    if (!detailsLookup.has(metafeed)) {

      // !detailsLookup.has(metafeed) !== "metafeed is a root)
      // this assumes that we have replicated the metafeed tree in the order
      // that it was created.

Need to watch for this being a problem if we do any fancy out of order replication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant