Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect too big group tangle previous array by failing to publish, and prune it #19

Merged
merged 5 commits into from Oct 27, 2022
Merged

Detect too big group tangle previous array by failing to publish, and prune it #19

merged 5 commits into from Oct 27, 2022

Conversation

Powersource
Copy link
Collaborator

@Powersource Powersource commented Oct 21, 2022 •
edited

As an alternative to calculating the size #8

  • Import needed code from other PR
  • Remove unused code
  • Add test with 5000 msgs and time it

@staltz
Copy link
Member

staltz commented Oct 21, 2022

So far looking good!

@Powersource Powersource marked this pull request as ready for review October 21, 2022 16:24
@Powersource Powersource mentioned this pull request Oct 24, 2022
Closed
mixmix
mixmix reviewed Oct 25, 2022
View reviewed changes
test/tangle-prune.test.js Outdated Show resolved Hide resolved
mixmix
mixmix requested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Nice succinct solution + tests, great work.
One minor request, could be a pre-optimisation but keen to have in in as had similar behaviour previously and worked well

@Powersource Powersource mentioned this pull request Oct 25, 2022
Open
mixmix
mixmix approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

NICE

@staltz
Copy link
Member

staltz commented Oct 26, 2022

Can we get tests passing before merging?

@Powersource Powersource merged commit d8fb22d into master Oct 27, 2022
@Powersource Powersource deleted the prune-yolo branch October 27, 2022 10:30
@Powersource Powersource mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arj03 arj03 arj03 left review comments

@mixmix mixmix mixmix approved these changes

@staltz staltz Awaiting requested review from staltz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Powersource @staltz @arj03 @mixmix