Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-addition add-member messages should be published on the additions feed instead #79

Closed
Powersource opened this issue Mar 24, 2023 · 3 comments
Assignees
Labels
must Needed to complete grant milestone

Comments

@Powersource
Copy link
Collaborator

Powersource commented Mar 24, 2023

Nice optimization to have them on the old epochs, in theory, but it increases complexity that we can't handle right now. Doing it this way will fix 2 issues:

  1. Can't re-add people to a new epoch if they haven't posted to the old epoch, since triangulation fails. Found here People not removed in an exclude should be able to post on the new epoch #78 (comment)
  2. There's a bug in box2 where triangulation fails if you create your feed after you find the other person's. If we just rely on the additions feed (which we create as soon as possible) this should fix itself People not removed in an exclude should be able to post on the new epoch #78 (comment)
@Powersource

This comment was marked as duplicate.

@Powersource
Copy link
Collaborator Author

  1. hopefully doesn't even bite us in prod, since people should only replicate additions feeds once we replicate metafeeds, and people will probably only do that once they themselves have groups/metafeeds and therefore called start() and have their own additions feed

@Powersource Powersource changed the title Can't re-add people to a new epoch if they haven't posted to the old epoch, since triangulation fails Re-addition add-member messages should also be published on the additions feed Mar 31, 2023
@Powersource Powersource changed the title Re-addition add-member messages should also be published on the additions feed Re-addition add-member messages should be published on the additions feed instead Mar 31, 2023
@Powersource Powersource self-assigned this Mar 31, 2023
@Powersource
Copy link
Collaborator Author

#85 seems to have fixed all the issues in #78

@mixmix you might be unblocked already. if not then you might have to wait for #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must Needed to complete grant milestone
Projects
None yet
Development

No branches or pull requests

1 participant