Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule] [Optane] [ipmctl_show_-a_-goal] Check for uncommitted goals #46

Closed
sscargal opened this issue Feb 4, 2022 · 2 comments · Fixed by #98
Closed

[Rule] [Optane] [ipmctl_show_-a_-goal] Check for uncommitted goals #46

sscargal opened this issue Feb 4, 2022 · 2 comments · Fixed by #98
Assignees
Labels
rule Create a new rule
Milestone

Comments

@sscargal
Copy link
Owner

sscargal commented Feb 4, 2022

Analyzer Module: Optane
Input File: ipmctl_show_-a_-goal
Applies to: Optane 100 or later
Description: This rule should check if an uncommitted goal is present

Rule Passes:

There are no goal configs defined in the system.
Please use 'show -region' to display currently valid persistent memory regions.
@sscargal sscargal added the rule Create a new rule label Feb 4, 2022
@sscargal sscargal added this to the Version 1.0.0 milestone Feb 4, 2022
@asemmaa asemmaa self-assigned this Feb 10, 2022
@asemmaa
Copy link
Collaborator

asemmaa commented Feb 16, 2022

"There are no goal configs defined in the system.
Please use 'show -region' to display currently valid persistent memory regions."

This is the only output there is from using ipmctl_show_-a_-goal command. Should we just check if the output is something other than this? Or is there more to this test

@sscargal
Copy link
Owner Author

That's the expected output for the PASS case. Anything else would need to be reported to the user with a message similar to "A pending goal configuration exists and will be applied on the next system reboot"

@asemmaa asemmaa mentioned this issue Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Create a new rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants