Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pep tools #29

Merged
merged 16 commits into from Oct 22, 2018
Merged

Rename pep tools #29

merged 16 commits into from Oct 22, 2018

Conversation

tdenewiler
Copy link
Contributor

@creffett, this addresses #28.

I renamed the tools and added warnings about the usage of the old names. If you want to see the warnings you can edit statick_tool/rsc/config.yaml for the self_check level to add in pep257 and pep8. Then run from this branch and do:

./statick . statick_output/ --profile self_check.yaml

You should see some of the output show:

DEPRECATION WARNING: The pep257 tool has been renamed as the pydocstyle tool. Please update your configuration.
Running pydocstyle tool plugin...
DEPRECATION WARNING: The tool name changed from pep257 to pydocstyle. Please update your configuration file to use the new tool name.
pydocstyle tool plugin done.

@tdenewiler
Copy link
Contributor Author

@creffett, I'll wait to merge this until you let me know if this is what you had in mind.

Copy link
Contributor

@creffett creffett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@denewiler denewiler merged commit 9363d1a into sscpac:master Oct 22, 2018
axydes pushed a commit to axydes/statick that referenced this pull request Jan 29, 2020
* Renamed pep8 and pep257 tools to pycodestyle and pydocstyle. Added deprecation warnings for the previous names when used as tools and in configuration files. This is following upstream changes to the names of the tools themselves.

* Using existing requirements.txt to install dependencies in Travis. This is to pick up any new packages that are added and necessary for testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants