Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of "admin.com" default admin user email #3946

Closed
1 task done
timptner opened this issue Jan 5, 2023 · 2 comments
Closed
1 task done

Remove use of "admin.com" default admin user email #3946

timptner opened this issue Jan 5, 2023 · 2 comments

Comments

@timptner
Copy link

timptner commented Jan 5, 2023

Describe the feature you'd like

Instead of using admin.com as default domain better us example.com or example.org. The domain admin.com resolves to a privately owned website whereas example.com and example.org are special domains, which are valid and provided by ICANN for testing purposes.

When a user logs in the first time on a fresh install of BookStack with the default admin credentials and tests the email settings one will successfully send an email but also get a bounce from admin@admin.com. This is bad for the reputation of the email server (either self hosted or third party service).

To solve this issue it's a better solution to use admin@example.com because when sending emails to this address the email will get successfully send and delivered.

Describe the benefits this would bring to existing BookStack users

Testing email delivery on a fresh install will not result in a bounced email.

Can the goal of this request already be achieved via other means?

Changing the default mail address of the admin user to a personal mail address.

This feature request will prevent bounced emails even if a user forgets to change the mail address before testing email settings.

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?

1 to 5 years

Additional context

No response

@timptner
Copy link
Author

timptner commented Jan 5, 2023

Issue #602 requests similar change but does not mention the disadvantages of using admin.com.

@ssddanbrown ssddanbrown changed the title Improve default admin email Remove use of "admin.com" default admin user email Jan 5, 2023
@ssddanbrown
Copy link
Member

Thanks for raising @timptner.
I'm going to close this in favour of centralising things in #4575, where a plan is put forward and tracked against for moving away from the existing default credential handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants