Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default user table migration #3947

Closed
wants to merge 1 commit into from
Closed

Update default user table migration #3947

wants to merge 1 commit into from

Conversation

timptner
Copy link

@timptner timptner commented Jan 5, 2023

Change default admin email to a valid domain for testing purposes provided by ICANN.

Change default admin email to a valid domain for testing purposes provided by ICANN.
@timptner timptner changed the title Update 2014_10_12_000000_create_users_table.php Update default user table migration Jan 5, 2023
@timptner
Copy link
Author

timptner commented Jan 5, 2023

Solves issue #3946.

@ssddanbrown
Copy link
Member

Thanks for offering this change @timptner but I'm going to close this off without merge.
Change of the default credentials will cause a lot of existing documentation & processes to become incorrect/outdated & in need of update, It would effectively be a breaking change in my view that requires some co-ordination and warning.

I do agree it would be good to move away from the existing credentials, but I don't think the reasons in #3946 are worth it alone. If we are to make changes to the default credential process, I'd like to do so as part of more substantial changes (An initial setup process or randomly generated default creds or something similar, needs some thought).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants