update: updated dependencies #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phbelitz
commented
Jun 2, 2023
•
phbelitz
commented
- updateing all outdated dependencies
- fix safety ci job
- remove legacy integration tests
The pip package safety needs gcc to be installed, which isn't present in the final connaisseur image. It also can be installed afterwards, since apk is no longer available. Thus safety is added to the final image, increasing image size by 5 mb.
The legacy integration tests required an outdated host (ubuntu 18.04) to be run on. Those hosts were removed on the 01.12.2022, thus the integration tests can no longer be run. Removing them.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| RUN apk add --no-cache \ | ||
| # also: safety needs gcc no properly install. gcc can't be installed in the final image, | ||
| # since apk is no longer available, so safety is added as package to the final image | ||
| RUN apk add --no-cache musl-dev gcc \ |
Check warning
Code scanning / Hadolint
Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version> Warning
chrysogonus
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.