Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pod securityContext to helm chart #1264

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

phbelitz
Copy link
Member

The current helm chart does not permit to add a pod-level security context, only a container-level security context. The helm chart is extended with an optional pod-level security context.

Fix #1240

duplicate of #1242

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c5c75ec) 96.41% compared to head (d0613fd) 96.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1264   +/-   ##
========================================
  Coverage    96.41%   96.41%           
========================================
  Files           23       23           
  Lines         1311     1311           
========================================
  Hits          1264     1264           
  Misses          47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xopham xopham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generall lgtm, just 1 minor comment

helm/values.yaml Show resolved Hide resolved
Copy link
Collaborator

@xopham xopham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Good stuff. Thx @hsudbrock

The current helm chart does not permit to add a pod-level security context, only a container-level security context. The helm chart is extended with an optional pod-level security context.

Fix #1240
@phbelitz phbelitz merged commit d0613fd into develop Sep 29, 2023
50 checks passed
@phbelitz phbelitz deleted the feat/podsecpol branch September 29, 2023 14:31
@hsudbrock
Copy link
Contributor

Thanks @xopham and @phbelitz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants