fix: health probe fails after some time #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #166 +/- ##
===========================================
+ Coverage 93.52% 96.78% +3.26%
===========================================
Files 15 22 +7
Lines 633 1059 +426
===========================================
+ Hits 592 1025 +433
+ Misses 41 34 -7
Continue to review full report at Codecov.
|
xopham
force-pushed
the
fix/fix-health-probe
branch
2 times, most recently
from
81a55ac
to
377d796
Compare
After installing connaisseur the health probe will fail after some time though it only returns true it runs health checks on validators that will not influence the health status but be logged if unhealthy. In case the health checks for the validators take too long, the pod health probe timeouts and the pod is considered unhealthy. Validator health checks are now separated from the pod health.
xopham
force-pushed
the
fix/fix-health-probe
branch
from
8ea6bde
to
4e79652
Compare
phbelitz
approved these changes
Jun 4, 2021
xopham
added a commit
that referenced
this pull request
Jun 5, 2021
After installing connaisseur the health probe will fail after some time though it only returns true it runs health checks on validators that will not influence the health status but be logged if unhealthy. In case the health checks for the validators take too long, the pod health probe timeouts and the pod is considered unhealthy. Validator health checks are now separated from the pod health.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installing connaisseur the health probe will fail after some time though it only returns true it runs health checks on validators that will not influence the health status but be logged if unhealthy. In case the health checks for the validators take too long, the pod health probe timeouts and the pod is considered unhealthy. Validator health checks are now separated from the pod health.