-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only load required delegantions #318
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #318 +/- ##
===========================================
- Coverage 96.65% 96.56% -0.10%
===========================================
Files 22 22
Lines 1077 1076 -1
===========================================
- Hits 1041 1039 -2
- Misses 36 37 +1
Continue to review full report at Codecov.
|
64aae21
to
164b4fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a test to highlight and ensure the functional diff
164b4fc
to
f282d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit has delegantions
, other than that lgtm
22021d7
to
c8f3681
Compare
OKOKOK. I had to change the code a bit after adding additional tests and realizing that there were some bugs... so the last commit adds 3 tests:
|
When using delegation for nv1, Connaisseur now only loads those delegation files it actually needs for verification and not all available. Additionally fixed a bug, where when a delegation role was present inside the `targets.json` but the actual delegation file was missing, Connaisseur would have raised a `KeyError`. This has been solved with proper error handling. fixes #171
c8f3681
to
b91d745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one catching the regression
When using delegation for nv1, Connaisseur now only loads those delegation files it actually needs for verification and not all available.
fixes #171