Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async image validation #334

Merged
merged 1 commit into from
Oct 22, 2021
Merged

feat: async image validation #334

merged 1 commit into from
Oct 22, 2021

Conversation

phbelitz
Copy link
Member

@phbelitz phbelitz commented Oct 1, 2021

Connaisseur now validates all images in side a single request in parallel.

fixes #226

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #334 (c5a6a18) into develop (f4b0728) will decrease coverage by 0.15%.
The diff coverage is 87.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #334      +/-   ##
===========================================
- Coverage    96.65%   96.49%   -0.16%     
===========================================
  Files           22       22              
  Lines         1077     1085       +8     
===========================================
+ Hits          1041     1047       +6     
- Misses          36       38       +2     
Impacted Files Coverage Δ
connaisseur/flask_server.py 92.92% <84.84%> (-1.58%) ⬇️
connaisseur/validators/cosign/cosign_validator.py 98.61% <100.00%> (ø)
connaisseur/validators/interface.py 100.00% <100.00%> (ø)
...naisseur/validators/notaryv1/notaryv1_validator.py 95.83% <100.00%> (ø)
...naisseur/validators/notaryv2/notaryv2_validator.py 80.00% <100.00%> (ø)
connaisseur/validators/static/static_validator.py 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b0728...c5a6a18. Read the comment docs.

helm/values.yaml Outdated Show resolved Hide resolved
connaisseur/flask_server.py Outdated Show resolved Hide resolved
connaisseur/flask_server.py Outdated Show resolved Hide resolved
connaisseur/flask_server.py Outdated Show resolved Hide resolved
connaisseur/flask_server.py Show resolved Hide resolved
connaisseur/flask_server.py Outdated Show resolved Hide resolved
@phbelitz phbelitz force-pushed the feat/async-image branch 3 times, most recently from a73f437 to 17f7625 Compare October 20, 2021 15:22
Starkteetje
Starkteetje previously approved these changes Oct 22, 2021
@xopham xopham mentioned this pull request Oct 22, 2021
3 tasks
Connaisseur now validates all images inside a single request in parallel.

fixes #226
@phbelitz phbelitz merged commit 8eab731 into develop Oct 22, 2021
@phbelitz phbelitz deleted the feat/async-image branch October 22, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants