Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cosign kms support #360

Merged
merged 1 commit into from
Oct 15, 2021
Merged

feat: cosign kms support #360

merged 1 commit into from
Oct 15, 2021

Conversation

xopham
Copy link
Collaborator

@xopham xopham commented Oct 14, 2021

fixes #325 #352

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #360 (7cd5f2f) into develop (bd3a155) will decrease coverage by 0.16%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #360      +/-   ##
===========================================
- Coverage    97.02%   96.85%   -0.17%     
===========================================
  Files           21       21              
  Lines         1042     1050       +8     
===========================================
+ Hits          1011     1017       +6     
- Misses          31       33       +2     
Impacted Files Coverage Δ
connaisseur/validators/cosign/cosign_validator.py 96.25% <81.81%> (-2.37%) ⬇️
...naisseur/validators/notaryv1/notaryv1_validator.py 95.79% <0.00%> (-0.04%) ⬇️
connaisseur/util.py 95.34% <0.00%> (ø)
connaisseur/config.py 97.32% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd3a155...7cd5f2f. Read the comment docs.

@xopham xopham marked this pull request as ready for review October 15, 2021 14:08
@xopham xopham force-pushed the feat/support-cosing-kms branch 2 times, most recently from d531a96 to ecafbcc Compare October 15, 2021 14:56
@phbelitz phbelitz added this to the v2.2.0 milestone Oct 15, 2021
@xopham xopham merged commit d5effb3 into develop Oct 15, 2021
@phbelitz phbelitz deleted the feat/support-cosing-kms branch October 15, 2021 15:52
@phbelitz phbelitz mentioned this pull request Oct 15, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants