Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changelogger #361

Merged
merged 1 commit into from
Oct 15, 2021
Merged

fix: changelogger #361

merged 1 commit into from
Oct 15, 2021

Conversation

phbelitz
Copy link
Member

The changelogger now respects the Github ratelimit when making its requests. Additionally, a token can be passed to decrease the ratelimit.

The changelogger now respects the Github ratelimit when making its requests. Additionally, a token can be passed to decrease the ratelimit.
@codecov-commenter
Copy link

Codecov Report

Merging #361 (bd3a155) into develop (a25d92f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #361   +/-   ##
========================================
  Coverage    97.02%   97.02%           
========================================
  Files           21       21           
  Lines         1042     1042           
========================================
  Hits          1011     1011           
  Misses          31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25d92f...bd3a155. Read the comment docs.

Copy link
Member

@Starkteetje Starkteetje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The token doesn't decrease the rate limit, it increases it. It decreases the time you have to wait

@phbelitz phbelitz merged commit bd3a155 into develop Oct 15, 2021
@phbelitz phbelitz deleted the fix/fix-changelogger branch October 15, 2021 09:37
@phbelitz phbelitz mentioned this pull request Oct 15, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants