fix: Handle invalid admission requests #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #363 +/- ##
===========================================
+ Coverage 96.85% 96.88% +0.02%
===========================================
Files 21 21
Lines 1050 1058 +8
===========================================
+ Hits 1017 1025 +8
Misses 33 33
Continue to review full report at Codecov.
|
Starkteetje
force-pushed
the
handle-invalid-requests
branch
from
183cbf6
to
218b466
Compare
Starkteetje
force-pushed
the
handle-invalid-requests
branch
from
7ce7e21
to
e3506e4
Compare
annekebr
previously approved these changes
Oct 29, 2021
This commit adds graceful handling to Connaisseur receiving syntactically invalid admission requests, such that e.g. an alert can be sent out that admission failed
Starkteetje
force-pushed
the
handle-invalid-requests
branch
from
e3506e4
to
80948ab
Compare
annekebr
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds graceful handling to Connaisseur receiving syntactically invalid admission requests, such that e.g. an alert can be sent out that admission failed