Allow CAPS in image tag

[hsuchan]

Only tags can have uppercase characters.
Excluding tags from lowercase comparison.

[phbelitz]

please add another test case in tests/test_image.py, or tell me if I should do the changes :) thank you very much for your support!

[hsuchan]

please add another test case in tests/test_image.py, or tell me if I should do the changes :) thank you very much for your support!

I added a test case for tag using uppercase letter.

[xopham]

@hsuchan lgtm!

Could you adjust the commit message to follow the semantic and conventional commits as described in the contributing guide. Should be something along the lines:

fix: allow CAPS in image tag

fixes #392 

We would then need rebase to develop again, sign it and could probably merge it.

Thanks for contributing 🙏

[hsuchan]

I did rebase to develop. Let me know if I did it correctly.

[xopham]

Suggested change

	None,
	"library",

This needs to be the repository value which is "library" in your case, as given in line 8 though I admit the description is a bit confusing

[hsuchan]

I was just copying the previous test ("docker.io/Library/image:tag") and changed the test case.
I also noticed that the repository was set to "None" but reasoned that any Image under docker.io/library can be called by it's short name:

docker pull docker.io/library/nginx
docker pull library/nginx
docker pull nginx

Let me know if you want me to change the repository to "library"

[hsuchan]

I made the suggested change.

[xopham]

I see what you mean. That is, however, only a unit test that does not take the docker.io specifics into account. I agree that specifically choosing library as a repo name in the previous example is confusing though.

thanks, looks good now.

[hsuchan]

I also signed my commit.

[codecov-commenter]

Codecov Report

Merging #393 (63b84b7) into develop (8eab731) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #393   +/-   ##
========================================
  Coverage    96.68%   96.68%           
========================================
  Files           21       21           
  Lines         1057     1057           
========================================
  Hits          1022     1022           
  Misses          35       35           

Impacted Files	Coverage Δ
connaisseur/image.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eab731...63b84b7. Read the comment docs.

[xopham]

@hsuchan great work 🙏
I briefly fixed the minor test issue. looks perfect now 🙂

requested changes were implemented

[xopham]

forgot to sign the commit previously 😅
will merge now 🚀