-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support api versions for k8s workloadobjects, add tests #396
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #396 +/- ##
========================================
Coverage 96.68% 96.68%
========================================
Files 21 21
Lines 1057 1057
========================================
Hits 1022 1022
Misses 35 35
Continue to review full report at Codecov.
|
@annekebr but then this pr fails. I renamed the pr to make it: fixing the workload object api versions, added tests accordingly. Would that work? |
echo -e "\n** Deploy '${KIND}' using '${APIVERSION}' and '${TAG}' image" | ||
envsubst < tests/integration/workload-objects/${KIND}.yaml | kubectl apply -f - >output.log 2>&1 || true | ||
|
||
if [[ ! "$(cat output.log)" =~ 'Unable to find signed digest for image docker.io/securesystemsengineering/testimage:unsigned.' ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be sufficient to deploy a valid signed image without error, wouldn't it? But as long as we don't run into timing issues, I don't mind testing more :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is what I thought and it seems that the k3s never fails with timing issues
4a8ccd5
to
8935784
Compare
8935784
to
ac212a3
Compare
fixes #382
description
checklist