Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support api versions for k8s workloadobjects, add tests #396

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

xopham
Copy link
Collaborator

@xopham xopham commented Oct 29, 2021

fixes #382

description

  • adds integration tests for workload objects and api versions for each Kubernetes version
  • fixes currently unsupported api versions

checklist

  • according to Contributing guide
  • tests added where necessary

@codecov-commenter
Copy link

Codecov Report

Merging #396 (4a8ccd5) into develop (8eab731) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #396   +/-   ##
========================================
  Coverage    96.68%   96.68%           
========================================
  Files           21       21           
  Lines         1057     1057           
========================================
  Hits          1022     1022           
  Misses          35       35           
Impacted Files Coverage Δ
connaisseur/workload_object.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eab731...4a8ccd5. Read the comment docs.

@xopham xopham requested a review from phbelitz November 5, 2021 08:55
@xopham xopham changed the title Test/k8s workloadobjects fix: support api versions for k8s workloadobjects, add tests Nov 5, 2021
@xopham
Copy link
Collaborator Author

xopham commented Nov 5, 2021

@annekebr but then this pr fails. I renamed the pr to make it: fixing the workload object api versions, added tests accordingly. Would that work?

echo -e "\n** Deploy '${KIND}' using '${APIVERSION}' and '${TAG}' image"
envsubst < tests/integration/workload-objects/${KIND}.yaml | kubectl apply -f - >output.log 2>&1 || true

if [[ ! "$(cat output.log)" =~ 'Unable to find signed digest for image docker.io/securesystemsengineering/testimage:unsigned.' ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be sufficient to deploy a valid signed image without error, wouldn't it? But as long as we don't run into timing issues, I don't mind testing more :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is what I thought and it seems that the k3s never fails with timing issues

annekebr
annekebr previously approved these changes Nov 5, 2021
@xopham xopham merged commit ac212a3 into develop Nov 5, 2021
@xopham xopham deleted the test/k8s-workloadobjects branch November 5, 2021 12:51
@phbelitz phbelitz mentioned this pull request Nov 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update supported k8s resources and api version
3 participants