Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: cosign v1.2.1 to v1.3.0 #404

Merged
merged 1 commit into from
Nov 5, 2021
Merged

update: cosign v1.2.1 to v1.3.0 #404

merged 1 commit into from
Nov 5, 2021

Conversation

xopham
Copy link
Collaborator

@xopham xopham commented Nov 5, 2021

Fixes no issue

Description

  • updates cosign to v1.3.0
  • fixes 1 vulnerabilities introduced via cosign
  • some configuration and outputs of cosign were changed and had to be adjusted

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #404 (32cd4ad) into develop (232e5b7) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #404      +/-   ##
===========================================
+ Coverage    96.68%   96.99%   +0.30%     
===========================================
  Files           21       21              
  Lines         1057     1064       +7     
===========================================
+ Hits          1022     1032      +10     
+ Misses          35       32       -3     
Impacted Files Coverage Δ
connaisseur/validators/cosign/cosign_validator.py 96.25% <100.00%> (ø)
connaisseur/alert.py 97.93% <0.00%> (+0.13%) ⬆️
connaisseur/flask_server.py 91.46% <0.00%> (+0.21%) ⬆️
...naisseur/validators/notaryv1/notaryv1_validator.py 98.30% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232e5b7...32cd4ad. Read the comment docs.

Copy link
Member

@Starkteetje Starkteetje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xopham xopham merged commit b36dab7 into develop Nov 5, 2021
@xopham xopham deleted the update/cosign-1.3 branch November 5, 2021 16:02
@phbelitz phbelitz mentioned this pull request Nov 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants