Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: cosign key types #415

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Refactor: cosign key types #415

merged 1 commit into from
Nov 14, 2021

Conversation

xopham
Copy link
Collaborator

@xopham xopham commented Nov 12, 2021

Fixes no issue

Description

  • several different types of keys (ecdsa, rsa) and references (email, kms) are being added to cosign and integrated for connaisseur
  • the handling and identification of key type is being refactored to improve extension

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #415 (ecbbcd8) into develop (f035e57) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #415      +/-   ##
===========================================
+ Coverage    94.24%   94.45%   +0.21%     
===========================================
  Files           22       22              
  Lines         1095     1101       +6     
===========================================
+ Hits          1032     1040       +8     
+ Misses          63       61       -2     
Impacted Files Coverage Δ
connaisseur/validators/cosign/cosign_validator.py 98.83% <100.00%> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f035e57...ecbbcd8. Read the comment docs.

@xopham xopham force-pushed the refactor/cosign-key-types branch 3 times, most recently from 8176c27 to 5978a97 Compare November 12, 2021 17:56
@xopham xopham marked this pull request as ready for review November 12, 2021 17:57
Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Nits only.

For the record, you may be able to do achieve a similar thing using new syntax from https://www.python.org/dev/peps/pep-0636/ (starting Python 3.10). However, it would be not what the new syntax is meant for, which reduces clarity, so I'd advise against it.

connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
connaisseur/validators/cosign/cosign_validator.py Outdated Show resolved Hide resolved
peterthomassen
peterthomassen previously approved these changes Nov 13, 2021
Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xopham xopham merged commit b7b2f05 into develop Nov 14, 2021
@phbelitz phbelitz mentioned this pull request Nov 23, 2021
3 tasks
@xopham xopham deleted the refactor/cosign-key-types branch November 23, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants