-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: cosign key types #415
Conversation
1957ea4
to
d57ff4f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #415 +/- ##
===========================================
+ Coverage 94.24% 94.45% +0.21%
===========================================
Files 22 22
Lines 1095 1101 +6
===========================================
+ Hits 1032 1040 +8
+ Misses 63 61 -2
Continue to review full report at Codecov.
|
8176c27
to
5978a97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Nits only.
For the record, you may be able to do achieve a similar thing using new syntax from https://www.python.org/dev/peps/pep-0636/ (starting Python 3.10). However, it would be not what the new syntax is meant for, which reduces clarity, so I'd advise against it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ecbbcd8
to
b7b2f05
Compare
Fixes no issue
Description
Checklist
develop
values.yaml
andChart.yaml
(if necessary)