New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support cosign --k8s-keychain flag #551
feat: Support cosign --k8s-keychain flag #551
Conversation
bc0367b
to
4a83462
Compare
I can add a test if necessary but it's a small change and any test would probably be contrived. Let me know if you think I should. This is ready for review. |
4a83462
to
1c36bfc
Compare
@phbelitz Doesn't look like I have permission to request a review. Would you mind taking a look at some point? |
Codecov Report
@@ Coverage Diff @@
## develop #551 +/- ##
===========================================
+ Coverage 94.23% 94.24% +0.01%
===========================================
Files 22 22
Lines 1127 1129 +2
===========================================
+ Hits 1062 1064 +2
Misses 65 65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marckn0x this is an awesome feature 🎉 Must have slipped my attention, but great that you picked it up 🚀
I have some comments. Did you make a functional test of the feature in your environment?
I'd prefer if a small test was added to the pytests, maybe around here, though I admit this may be of limited use.
Please, adjust the commit message to something like feat: Support cosign --k8s-keychain flag
in order to follow semantic and conventional commit messages as described in the contributing guide (just noticed the link in the PR template is broken 🙈).
f08e16e
to
f62ff7c
Compare
I added a test in the location suggested; thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few last changes and after that we're good to go 🚀
9fdef68
to
ee14051
Compare
17a8195
to
ec8991e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a proposal for the tests. If that works for you, feel free to squash and I'd be happy to approve 🙂
ec8991e
to
c905c79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marckn0x thanks for the great contribution 🚀
Fixes #390
Description
Add configuration option
k8s_keychain
forcosign
validator that will pass the flag--k8s-keychain
tocosign
when set to true. This allowscosign
to pick up registry credentials from the environment (see sigstore/cosign#972 for details)Checklist
develop