ci: add build step #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 14 14
Lines 628 628
=======================================
Hits 585 585
Misses 43 43 Continue to review full report at Codecov.
|
xopham
force-pushed
the
ci/add-build-step
branch
from
2953882
to
e208cf4
Compare
xopham
force-pushed
the
ci/add-build-step
branch
3 times, most recently
from
18b4c3b
to
5828eac
Compare
xopham
force-pushed
the
ci/add-build-step
branch
2 times, most recently
from
da00ffa
to
f7bc8ef
Compare
| with: | ||
| name: images | ||
| path: images | ||
|
|
There was a problem hiding this comment.
Would add retention-days: 1
| # ignore Markdown files | ||
| *.md | ||
| # ignore tests | ||
| connaisseur/tests/ |
There was a problem hiding this comment.
If you want marginally faster builds, you can also add img/ since that accounts for ~2/3 of the repo size
There was a problem hiding this comment.
think that is excluded anyways. Checking...
There was a problem hiding this comment.
For build size, it is, since its not used. But for speed during building, the whole context (the . for docker build . ) is copied to the docker daemon. Is local copy of few MB, so 🤷♂️ , but if we put a 1GB file in that folder you'll notice
There was a problem hiding this comment.
will however only increase the build speed, but good point!
.github/workflows/cicd.yaml
Outdated
| run: | | ||
| mkdir images | ||
| docker save ${RELEASE_IMAGE}:${RELEASE_VERSION} -o images/${GITHUB_SHA}_image.tar | ||
| docker save ${RELEASE_IMAGE}:helm-hook -o images/${GITHUB_SHA}_hook.tar |
There was a problem hiding this comment.
Maybe out of scope for this PR, but we are not versioning the helm-hook here, so we technically can't change the hook script without changing naming here (or we break older versions on redeployment), right?
There was a problem hiding this comment.
added to release discussion
xopham
force-pushed
the
ci/add-build-step
branch
from
f7bc8ef
to
c345ca4
Compare
xopham
force-pushed
the
ci/add-build-step
branch
from
9090f0b
to
d0618b5
Compare
phbelitz
force-pushed
the
ci/add-build-step
branch
from
6a51ec8
to
e1d8b14
Compare
Originally, the Connaisseur docker image is built in multiple later steps of the pipeline. This causes code duplication, maintenance increase, unintuitive failing and unnecessary ci run time. Fixes #54
Separation of python dependencies for development and production. Adding .dockerignore to exclude unnecessary files. Implementing multi-stage build to reduce build dependencies.
phbelitz
force-pushed
the
ci/add-build-step
branch
from
e1d8b14
to
a7cc5de
Compare
Originally, the Connaisseur docker image is built in multiple later steps of the pipeline. This causes code duplication, maintenance increase, unintuitive failing and unnecessary ci run time.
Fixes #54