Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ghcr, signatures, sboms, slsa, reusable workflows, ossf #622

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

xopham
Copy link
Collaborator

@xopham xopham commented Apr 8, 2022

Fixes #624

Description

Major changes:

  • new build system
    • implement GHCR to store images as packages in pipeline
    • use buildkit for image build -> SBOMs, Provenance
    • sign packages using cosign
  • modular CI (reusable workflows and actions)
  • refactor CI

Improvements:

  • integrated with GitHub Security
  • modular CI
  • faster builds
  • signed builds
  • nightly builds
  • provenance and SBOMs added
  • broader code scanning coverage

TBD:

  • summary update
  • rm trivy-released-image-scan into sca job
  • join docs into main workflows
  • update "required tests"
  • matrix strategy for dockerhub-check

Open Question:

  • OK to add registry to helm chart? seems more explicit and less reliant on a random default
  • OK to rename "nightly-scans" to "nightly"?
  • can we drop tag engineering?
  • should we make everything reusable with selector for which jobs to drop?
  • now only relying on Github security not pipeline fail
  • IMPORANT: mitigate risk of overwriting tags!

Missing (create issues for remaining):

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Base: 97.13% // Head: 97.13% // No change to project coverage 👍

Coverage data is based on head (391222d) compared to base (eea60b7).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #622   +/-   ##
========================================
  Coverage    97.13%   97.13%           
========================================
  Files           23       23           
  Lines         1290     1290           
========================================
  Hits          1253     1253           
  Misses          37       37           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xopham xopham linked an issue Apr 9, 2022 that may be closed by this pull request
@xopham xopham force-pushed the ci/use-ghcr branch 5 times, most recently from 59f111d to fc2f699 Compare February 10, 2023 21:19
@xopham xopham force-pushed the ci/use-ghcr branch 11 times, most recently from 4e4e205 to 7c0eaa4 Compare February 17, 2023 11:24
@xopham xopham marked this pull request as ready for review February 17, 2023 11:33
@xopham xopham force-pushed the ci/use-ghcr branch 2 times, most recently from 991a9fa to e08f6c9 Compare February 17, 2023 12:03
@xopham xopham requested review from phbelitz and Starkteetje and removed request for phbelitz February 17, 2023 13:29
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
.github/workflows/nightly-scans.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/nightly-scans.yaml Show resolved Hide resolved
tests/integration/integration-test.sh Show resolved Hide resolved
@xopham xopham force-pushed the ci/use-ghcr branch 2 times, most recently from 44e3aec to 75c5886 Compare February 17, 2023 14:56
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
.github/workflows/nightly-scans.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
tests/integration/integration-test.sh Outdated Show resolved Hide resolved
tests/integration/integration-test.sh Outdated Show resolved Hide resolved
tests/integration/update-for-workloads.yaml Show resolved Hide resolved
.github/actions/context/action.yaml Outdated Show resolved Hide resolved
.github/actions/build/action.yml Outdated Show resolved Hide resolved
.github/actions/build/action.yml Outdated Show resolved Hide resolved
@xopham xopham force-pushed the ci/use-ghcr branch 21 times, most recently from 776a79c to 1c9c05a Compare February 24, 2023 17:26
@xopham xopham changed the title ci: use ghcr for ci ci: use ghcr, signatures, sboms, slsa, reusable workflows, ossf Feb 24, 2023
@xopham xopham merged commit 98ce403 into develop Feb 24, 2023
This was referenced Feb 24, 2023
@Starkteetje Starkteetje deleted the ci/use-ghcr branch November 21, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Container Registry for CI
4 participants