fix/test: Fix handling of invalid requests, increase test coverage #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starkteetje
force-pushed
the
test/test-coverage
branch
from
97588bf
to
0c5d8af
Compare
Codecov Report
@@ Coverage Diff @@
## develop #63 +/- ##
==========================================
Coverage ? 96.20%
==========================================
Files ? 15
Lines ? 633
Branches ? 0
==========================================
Hits ? 609
Misses ? 24
Partials ? 0 Continue to review full report at Codecov.
|
peterthomassen
requested changes
Nov 20, 2020
Starkteetje
force-pushed
the
test/test-coverage
branch
from
0c5d8af
to
ff53278
Compare
phbelitz
force-pushed
the
test/test-coverage
branch
from
ff53278
to
c0df647
Compare
phbelitz
force-pushed
the
test/test-coverage
branch
3 times, most recently
from
65334bc
to
c696717
Compare
phbelitz
force-pushed
the
test/test-coverage
branch
from
c696717
to
d7873de
Compare
Previously the Connaisseur logger may have failed to properly log invalid requests. Increase test coverage for flask server. Prevent some tests from leaking environment variables beyond their scope.
phbelitz
force-pushed
the
test/test-coverage
branch
from
d7873de
to
5c326a1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Connaisseur logger may have failed to properly log invalid requests. Increase test coverage for flask server. Prevent some tests from leaking environment variables beyond their scope.