Fix/fix issues #812
Merged
Fix/fix issues #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbelitz
force-pushed
the
fix/fix-issues
branch
2 times, most recently
from
871ee4f
to
64fb46f
Compare
Codecov ReportBase: 96.81% // Head: 96.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #812 +/- ##
========================================
Coverage 96.81% 96.81%
========================================
Files 22 22
Lines 1226 1226
========================================
Hits 1187 1187
Misses 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phbelitz
force-pushed
the
fix/fix-issues
branch
from
cc618d8
to
b60de4e
Compare
Starkteetje
reviewed
Nov 4, 2022
phbelitz
force-pushed
the
fix/fix-issues
branch
from
6bd78b0
to
e6c6d45
Compare
There is a transitiv dependency on frozenlist, which updated their package for python 3.11, but didn't add the package to pypi wheels. Thus, building on python >= 3.11 fails the whole docker building process ([issue](aio-libs/frozenlist#342)). Need to add gcc and libc to docker container as well as upgrade pip to resolve this. Secondly, there are two more vulnerabilities due to cosign, which cannot be fixed on our side. Ignore listing them until cosign publishes a new version.
The upload of the code coverage has nothing to do with connaisseurs functionality and thus should be optional.
Cosign changed its error code for non existant images and missing signatures in transparency logs, resulting connaisseur in throwing wrong errors as well. This has been fixed.
phbelitz
force-pushed
the
fix/fix-issues
branch
from
02e9178
to
ad974f7
Compare
Starkteetje
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a transitiv dependency on frozenlist, which updated their package for python 3.11, but didn't add the package to pypi wheels. Thus, building on python >= 3.11 fails the whole docker building process (issue). Switching to python 3.10. Secondly, there are two more vulnerabilities due to cosign, which cannot be fixed on our side. Ignore listing them until cosign publishes a new version.
Checklist
developvalues.yamlandChart.yaml(if necessary)