docs/test: Documentation for image validation, improve validation test coverage #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterthomassen
requested changes
Feb 2, 2021
There was a problem hiding this comment.
very concise description of the algorithm! I like the sentence that ends with "validated in previous steps for later files" :)
Personally, I'd say that unrelated things (missing tests, and docs of something else) should go into different commits. I like having the upside of being able to revert a commit (e.g. when you don't want the tests anymore) without loosing something else unintentionally. (I'll approve regardless.)
Starkteetje
force-pushed
the
docstest-validation
branch
from
a0f7c59
to
6ec43c1
Compare
phbelitz
reviewed
Feb 4, 2021
Starkteetje
force-pushed
the
docstest-validation
branch
from
f4e69d9
to
ddae980
Compare
This commit documents the existing image validation procedure employed by Connaisseur
This commit adds some test cases for all supported and one unsupported Kubernetes resource, tests more invalid trust data and checks the combination of valid and invalid delegations alongside each other
Starkteetje
force-pushed
the
docstest-validation
branch
from
ddae980
to
64f7c84
Compare
phbelitz
approved these changes
Feb 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the existing validation procedure employed by Connaisseur. In addition, it adds some test cases for all supported and one unsupported Kubernetes resource, tests more invalid trust data and checks the combination of valid and invalid delegations alongside each other. Also typos