Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/fix/refactor: Check commit messages have identifier and small fixes #957

Merged
merged 3 commits into from
Mar 20, 2023
Merged

ci/fix/refactor: Check commit messages have identifier and small fixes #957

merged 3 commits into from
Mar 20, 2023

Conversation

Starkteetje
Copy link
Member

@Starkteetje Starkteetje commented Mar 20, 2023 •
edited

Adds a CI step that checks whether all added commits have an identifier like fix, ci or test in front of them as specified in CONTRIBUTING.MD

See e.g. https://github.com/sse-secure-systems/connaisseur/actions/runs/4467696912/jobs/7847485473 for output

Fixes wrongly named docs file and removes some whitespace

Fixes #905 #910

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

@github-advanced-security
Copy link

You have successfully added a new Scorecard configuration supply-chain/online-scm. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new Scorecard configuration supply-chain/local. As part of the setup process, we have scanned this repository and found 45 existing alerts. Please check the repository Security tab to see all alerts.

@Starkteetje Starkteetje force-pushed the ci-check-conform branch 6 times, most recently from 08908aa to 0d35402 Compare March 20, 2023 11:32
@Starkteetje Starkteetje marked this pull request as ready for review March 20, 2023 11:33
@Starkteetje Starkteetje changed the title ci: Check commit messages have identifier ci/fix/refactor: Check commit messages have identifier and small fixes Mar 20, 2023
phbelitz
phbelitz previously approved these changes Mar 20, 2023
View reviewed changes
.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
xopham
xopham requested changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@xopham xopham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should foster the new structure and maintain grouping

.github/workflows/cicd.yaml Outdated Show resolved Hide resolved
@Starkteetje
docs: Fix file name of automatic unchagend approval
7a8b18d 
Fix #910
@Starkteetje
refactor: Remove trailing spaces
22d176e
@Starkteetje
ci: Check commit messages have identifier
c63e173 
Adds a CI step that checks whether all added commits have an identifier like fix, ci or test in front of them as specified in CONTRIBUTING.MD

Fix #905
xopham
xopham approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@xopham xopham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Starkteetje Starkteetje merged commit c63e173 into develop Mar 20, 2023
@Starkteetje Starkteetje deleted the ci-check-conform branch March 20, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xopham xopham xopham approved these changes

@phbelitz phbelitz phbelitz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Starkteetje @xopham @phbelitz