Fix bash script sourcing with symbolic links #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kathys pointed out that she was getting errors during the initial steps of the software bundle scripts when it was trying to load the
env.shscript. This was broken as part of #680 because I made the scripts relative symbolic links and they were not being resolved to the absolute path correctly.This makes bash scripts depend on
readlink -fof the system to work. This should be fine on all modern versions of linux and probably most versions of BSD-based systems.Additionally, there was an old hdf5_backend.sh script which probably hasn't worked for years so I deleted it.