New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SIFT script to python package installation #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've waited long enough, let's merge this. @katherinekolman can continue work on understanding the matplotlib test failure in #286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
entry_point
to thesetup.py
file so when theuwsift
package is installed in an environment abin/SIFT
script will be made available to start SIFT.This is the first step in producing a conda-pack tarball for linux-installations. The current instructions (not in the official docs yet) are:
with a valid conda environment already activated. Note
uwsift
must be installed withpip install --no-deps
instead of the more typical development environment install ofpip install -e .
. The important part is the-e
. Doing it this way actually moves the uwsift files to the python environment instead of just linking them.Once we have this tarball we can then do the following to install it on another system:
CC @katherinekolman Could you test this branch and build instructions on your Mac?