Add support for Satpy 0.23+ and PROJ 6.0+ #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two huge updates from two of our dependencies:
DatasetID
object toDataID
objects andDataQuery
objects. Conceptually these should help separate the use cases of "I know exactly what I have and here is how it is identified" and "I don't know exactly what I want, but I'd like to query for these parameters". Functionally this requires a couple changes, but the main one is that DataID properties should be access as dictionary keys, not properties. This PR tries to support both old property/attribute access and dictionary getitem access to these properties. I've done some basic testing and things seem to work.+over
parameter. This was a "hack" that allowed us in the SIFT world to project coordinates that were outside of -180/180 space and pretend like they were in that space. This parameter is still used in SIFT's transformation code, but other areas needed to be updated. Mainly, handling of grib data that is 0-360 longitude is now swapped around to be -180/180 to fit in the primary SIFT viewing domain. I believe this changes how grib files were viewed previously which repeated the data from -180 to ~540 degrees longitude. This is no longer possible without some larger modifications to how SIFT handles projections and data (ex. making two copies of each image so it appears on both -180/180 and 180/540). Note that for all of this to work depends on yet another Satpy PR to fix the grib reader (I'll make this shortly).TODO: