Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Satpy 0.23+ and PROJ 6.0+ #301

Merged
merged 6 commits into from Dec 23, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 3, 2020

This PR fixes two huge updates from two of our dependencies:

  1. In Satpy PR Make the metadata keys that uniquely identify a DataArray (DataID) configurable per reader pytroll/satpy#1088, @mraspaud has migrated from a single over-purposed DatasetID object to DataID objects and DataQuery objects. Conceptually these should help separate the use cases of "I know exactly what I have and here is how it is identified" and "I don't know exactly what I want, but I'd like to query for these parameters". Functionally this requires a couple changes, but the main one is that DataID properties should be access as dictionary keys, not properties. This PR tries to support both old property/attribute access and dictionary getitem access to these properties. I've done some basic testing and things seem to work.
  2. Pyproj 2.x and PROJ 6.0+ no longer support the +over parameter. This was a "hack" that allowed us in the SIFT world to project coordinates that were outside of -180/180 space and pretend like they were in that space. This parameter is still used in SIFT's transformation code, but other areas needed to be updated. Mainly, handling of grib data that is 0-360 longitude is now swapped around to be -180/180 to fit in the primary SIFT viewing domain. I believe this changes how grib files were viewed previously which repeated the data from -180 to ~540 degrees longitude. This is no longer possible without some larger modifications to how SIFT handles projections and data (ex. making two copies of each image so it appears on both -180/180 and 180/540). Note that for all of this to work depends on yet another Satpy PR to fix the grib reader (I'll make this shortly).

TODO:

  • Add tests

@djhoese djhoese self-assigned this Aug 3, 2020
@djhoese
Copy link
Member Author

djhoese commented Aug 3, 2020

Related Satpy PR: pytroll/satpy#1296

@djhoese djhoese merged commit b3e81b0 into ssec:master Dec 23, 2020
@djhoese djhoese deleted the feature-satpy-dataids branch December 23, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant