Add times and expires to Entry and Group #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sseemayer
reviewed
Apr 22, 2021
|
Thank you for the compliment and the quick review. Please take a look at these two conversations and comment further when you have time: I will work on these changes over the weekend and resolve the associated conversations as I progress: |
|
Thanks also to you for the elaborations! I've added some further comments on the parse_xml_timestamp and pub times: HashMap discussions. |
sseemayer
approved these changes
Apr 23, 2021
|
Wonderful! 🎉 Thanks a lot for the nice contribution. |
|
Thank you again for the quick PR review and detailed feedback. |
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
* Add times and expires to Entry and Group * Updates from initial PR discussions Co-authored-by: John G. Russell <jgrgit@hiwt.com>
sseemayer
pushed a commit
that referenced
this pull request
Dec 30, 2022
* Add times and expires to Entry and Group * Updates from initial PR discussions Co-authored-by: John G. Russell <jgrgit@hiwt.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
ExpiryTimeentry from the XML; and, I think it sets the stage for quick and easy additions of other XML timestamp fields as needed/requested.It also adds and the
Expiresflag from the XML to bothGroupandEntrysinceExpiryTimeis almost meaningless without this flag.Please let me know if you want me to make any changes, anything from code tweaks to overall approach; or, feel free to edit my fork directly.
Once this is merged, #29 will be complete in my mind.
Thank you again!