Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashes for all systems #20

Open
sselph opened this issue Feb 3, 2015 · 174 comments
Open

Update hashes for all systems #20

sselph opened this issue Feb 3, 2015 · 174 comments
Assignees

Comments

@sselph
Copy link
Owner

sselph commented Feb 3, 2015

Need to update the dataset with all the new games in the GDB.

@sselph
Copy link
Owner Author

sselph commented Feb 3, 2015

Finished GG, GB, GBC, GBA

@sselph sselph self-assigned this Feb 3, 2015
@robertybob
Copy link

I found more GG games (24) I somehow missed from the thegamesdb - I've now added them to the website and this spreadsheet has the GameDB IDs for them

https://dl.dropboxusercontent.com/u/48342677/NEW%20GameGear%20IDs.csv

@sselph
Copy link
Owner Author

sselph commented Feb 5, 2015

Thanks. I added them all to the dataset and found some duplicate issues in the dataset and corrected those.

@robertybob
Copy link

Thanks !!

@sselph
Copy link
Owner Author

sselph commented Feb 9, 2015

Updated NES.

@sselph
Copy link
Owner Author

sselph commented Feb 25, 2015

finished SNES

@robertybob
Copy link

Hi @sselph , a few Genesis games that are currently missing (based on the ROMs I scraped)

https://dl.dropboxusercontent.com/u/48342677/Missing%20genesis.csv

edit

Also, If I can be a little bit picky, my Genesis 'Earthworm Jim (USA)' ROM links to ID 2894 , which is the Mega Drive version (they're identical except for the image), rather than the Genesis ID of 4353.

@robertybob
Copy link

@sselph
Copy link
Owner Author

sselph commented Mar 8, 2015

Thanks, I've added your entries.

@robertybob
Copy link

Hey. These two games result in duplicate entries (ID 611) - one should be ID 611 (vs. Kingpin), one should be 2620 (animated series).

@robertybob
Copy link

Hi @sselph , here are all of the GBA games I had that were missing an entry in TGDB. There are now IDs for all of them:

https://db.tt/tEW7B4X8

Can you let me know when your database has been updated? :)

@sselph
Copy link
Owner Author

sselph commented Apr 9, 2015

Sorry for the delay, I added your csv.

@BlackrosesXI
Copy link

I didn't realize there is a thread for that before I made mine. Support for Nintendo DS would be really appreciated. I have little knowledge in coding, but if it's a matter of time, I have time to spare. Thanks.

@Pacolo
Copy link

Pacolo commented May 5, 2015

Hi, I added this game to TGDB: http://thegamesdb.net/search/?string=Super+Soukoban&function=Search but the scraper can't find it.

Of course, the game is in No-Intro set: http://datomatic.no-intro.org/?page=show_record&s=49&n=2865

@sselph
Copy link
Owner Author

sselph commented May 6, 2015

@Pacolo I added this game.

@robertybob
Copy link

@sselph New GBA games to add to your list :) https://drive.google.com/file/d/0ByWwZdQX1FQmVEE2RGJsaUdxbTQ/view?usp=sharing

Could you let me know when they're added so I can re-scrape? Many thanks!

@sselph
Copy link
Owner Author

sselph commented Jun 21, 2015

@robertybob Added.

@robertybob
Copy link

Hi @sselph , just 5 Turbografx games missing from your scraper

https://www.dropbox.com/s/13lf004v2fiwiv5/Turbografx.csv?dl=0

@sselph
Copy link
Owner Author

sselph commented Aug 22, 2015

Done

@robertybob
Copy link

Hi again @sselph . Thank you for adding those TG16 games. I've now started importing PS1 games into my Pi. I just scraped 63 games, 35 downloaded images and details entered into the gamelist, yet running your reporting tool gives a figure of just over 50. Not sure what's going on there.

Either way, here's my hashes and TGDB IDs for inclusion onto your database :)

https://www.dropbox.com/s/3pavet9jjc4vyrq/PS1%20Missing.csv?dl=0

Thanks again! 👍

@sselph
Copy link
Owner Author

sselph commented Aug 31, 2015

The script checks the cue then the bins so it is possible the cues were correct since they are just a text file but the bin was slightly different. The reporter tool doesn't look at cue files so it isn't printing those. I can add these bin's in.

@robertybob
Copy link

Ah ok, that's where I'm going wrong- it's not finding the games because I haven't got any .cue files set up yet (?)

Also, I've got a few .img files, these aren't supported by your scraper yet are they IIRC?

@robertybob
Copy link

So basically without .bin support within the reporting tool, there's no way for me to gain the hashes of the games definitely not being picked up by the Scraper?

@adrianmoisey
Copy link

Do you take unlicensed games?
6cf18228cfb66d48b3642069979d4a5103cb8528,26500,7,Somari

@robertybob
Copy link

This scraper uses data from thegamesdb.net - if a game is on that site then this scraper should pick it up.

I should note, however, that unlicensed games and hacks are frowned upon on TGDB.net ..if you add that game it may well be deleted.

@adrianmoisey
Copy link

This scraper uses data from thegamesdb.net - if a game is on that site then this scraper should pick it up.

The game I added already has an entry on thegamesdb: http://thegamesdb.net/game/26500

It looks like quite a few Unlicensed games already exist in the csv:

~/.sselph-scraper$ grep \(Unl\) hash.csv | wc -l
601

I should note, however, that unlicensed games and hacks are frowned upon on TGDB.net ..if you add that game it may well be deleted.

I didn't add, someone else added it.

@adrianmoisey
Copy link

Do you mind using a version I just created that uses the same hashing algorithms that the scraper uses?

Ah, I didn't realise that you used your own hash. Sorry about that.
How's this:
bb618e17cd21eaa0185de3a3bf0028dcbba6a0c3,26500,7,Somari (Unl)

@ghost
Copy link

ghost commented Apr 27, 2017

@sselph: I will talk to the TGDB Administrators about it and see what we can do to prevent deletions. It's an issue that we need to correct.

I added another hash for Atari 2600. I have more on Atari 2600 to come.
https://drive.google.com/open?id=1jMyUI1Wwxlw592jJRSlzQ-9d4EuFWKKMQtAdRQCp314

@dvanthuyl
Copy link

Hi @sselph
2 classics for MSX. I think one or both of these are fan translations:
26942 Metal Gear 1 (1987) (Konami) (J).mx2,hash not found,8dfe236a6a5734824035725a4f513b8fd31b310a
26943 Metal Gear 2 - Solid Snake (1990) (Konami) (J).mx2,hash not found,7681b0dde4d2c40512e33afe9abc72b7ef591294

and a few translation patched roms for SNES:
1800 Dragon Ball Z - Hyper Dimension (Japan) [En by Unknown v1.0].sfc,hash not found,3e268078684d363b9aefe79667cdf5d1d389f1ca
9418 Final Fantasy IV (Japan) (Rev 1) [En by J2e v3.21] [Bug Fix by Deathlike2 v1.0a] (Yang's HP Fix).sfc,hash not found,388b5a07a8b76adee416cb601283618300a1c302
1762 Final Fantasy V (Japan) [En by RPGe v1.1].sfc,hash not found,8d5a83770c3d6f2b29b7825b5a17434616ec1c60
5839 Shin Kidou Senki Gundam W - Endless Duel (Japan) [En by Aeon Genesis v1.0].sfc,hash not found,cc0de241850e844d42ba512063733633df27a9d8
37642 Taekwon-Do (Japan) (Ja,Ko).sfc,hash not found,dc61cb9b82eb58a9b09cb93a10b6731eaa4cd053

@sselph
Copy link
Owner Author

sselph commented May 2, 2017

@dvanthuyl I added the translated SNES roms but I don't think I support MSX. I don't see any other MSX hashes and don't have mx2 as an extension.

@dd900
Copy link

dd900 commented May 4, 2017

@sselph Are you only using hashes for NES roms with headers? I have the latest No-Intro headerless set and I cannot find any matches.

Edit: Answered the question myself. And the answer is yes you only have hashes for roms with headers.

@sselph
Copy link
Owner Author

sselph commented May 4, 2017

I parse the headers of .nes files to find the rom information and hash that. If the files have no headers it is likely the code is still trying to parse one and is getting invalid data for the position and length of all the data.

I assume the headerless .nes is just a concatenation of the PRG and CHR data so if you shasum one you would get a hash that matches a No-Intro entry? If you want to get the sha1 hash of a common rom you can confirm my suspicion and I will add in some detection of the magic string in the header to know if it should be parsed.

@dd900
Copy link

dd900 commented May 4, 2017

Not sure if this helps but here is a DirToDat including sha1.

@sselph
Copy link
Owner Author

sselph commented May 4, 2017

Thanks, those seem to match. I'll work on adding the checks and tests.

@sselph
Copy link
Owner Author

sselph commented May 4, 2017

@dd900 Fixed it

@ghost
Copy link

ghost commented May 6, 2017

@sselph - Hot Off the Press!

Here is the completed set of all the .ctg files I could find for the TI-99/4A. There are more games which will be added in the future, but they are not yet converted to .ctg file type.

Notes:

  1. For the naming, I used a similar format to No-Intro to keep the clean appearance. This is similar to what we did with Intellivision (which turned out so nicely btw, thank you). The name format is different from the TI-99/4A names which are used on Atari-Age, this is on purpose to keep the names consistent to No-Intro

  2. The file names are different on three titles. The titles QBert, MASH, and Simon Says! all have illegal characters in the names. To not introduce any file errors, I replaced with dashes on the first two files and removed the ! on the last. If possible for display names however, it would be nice to have the illegal characters entered instead of using the nerfed file names. So if it is possible, let's go for it!

  3. On TGDB, I have all of the artwork created and am about halfway done with the descriptions / details. I am working through that the metadata so don't be surprised if on some of these titles only the artwork is displayed for now.

Here is the download for the TI-99/4A Game-Hashes:
https://drive.google.com/open?id=1Kn0cVSAcH-47xv5djfUklOyBZ5EXwAgFD7Cg4RNvG7M

Please let me know if there is anything I can do. I am sure there will be a few errors I will need to correct. I should have the metadata done on TGDB soon to match up with the existing artwork which I previously have created.

Thank you!

@sselph
Copy link
Owner Author

sselph commented May 6, 2017

@stevetb Thanks I've added these.

@ghost
Copy link

ghost commented May 6, 2017

@sselph

Could you please add these too please?
https://drive.google.com/open?id=1jMyUI1Wwxlw592jJRSlzQ-9d4EuFWKKMQtAdRQCp314

@sselph
Copy link
Owner Author

sselph commented May 10, 2017

@stevetb Thanks I've added these.

@marcteale
Copy link

@dvanthuyl
Copy link

Bare Knuckle III (Japan) [En by Twilight v1.0].md,hash not found,d1dc85abe0889ff8e880edcaf908a6b195b75952

english translation patched version for this one http://thegamesdb.net/game/25471/

@ghost
Copy link

ghost commented Jun 29, 2017

de475924bae6cbe7cabdc84ac4cb8aeec58f076e F-Zero (Europe).sfc
http://thegamesdb.net/game/43448

4b82c70824922380a3193e282d7674a442bd6dd4 Firemen, The (Europe) (En,Fr,De).sfc
http://thegamesdb.net/game/44784

@cbgoodman
Copy link

ef726908b18a5ead67b8024ef664cc708cdf402e is in the hash dataset; however, it is unlabeled. It's Final Fight CD (Sega CD) (U).bin.

@kodeFant
Copy link

Dear @sselph . Thanks for a great scraper.

Went through a bunch of games:
https://drive.google.com/file/d/0B777-EeiCezlYUZzVWowdjBJdUE/view?usp=sharing

@kaltinril
Copy link

I created a separate discussion. Proposal to create an auto gathering option for the scraper.

#176

@sselph
Copy link
Owner Author

sselph commented Sep 1, 2017

thanks everyone. I started adding all these but it is getting late and will continue tomorrow.

@sselph
Copy link
Owner Author

sselph commented Sep 9, 2017

@marcteale Thanks!
@dvanthuyl Thanks!
ghost Thanks! Whoever you were
@cbgoodman Thanks!

@larsparsfromage Thanks! There were a couple of games that didn't seem to line up

nes/Wizards & Warriors (U).zip NES 0305a626acdc6523ff168725c402c6f81ec5b106 26409 7
nes/Tecmo Cup - Soccer Game (U).zip NES cbdf18ccbce9edcf59b30d85281410b782fc8355 2133 7

The first the ID seems to be for a different game and the second the linked game seems to be slightly different than the one I have 2131. The hash is for the US version and I think the ID you gave is for an EU version. Also for neogeo it seemed like things were named in a non-standard way. I was lazy and just copied them in but you'll have to use -mame which you are probably aware of.

There were also a couple of Mega Drive vs Genesis. I made the choice for Multi-region games that include Genesis and Mega Drive to use the Genesis version if available since Genesis sold more consoles based on the very quick search I did. I really didn't care but had to make some choice so that is what it ended up being. If you use the ss source it can probably do better at handling getting MD images if you use -region="eu,wor,us,jp,fr,xx" or something like that to prefer the EU region over the US region.

@ericsnis
Copy link

Thanks for the scraper tool.
The scraper caught most of the ROMs but here are a few from the Super Nintendo which didn't get picked up.

Game Error Hash ID
Megaman X.smc hash not found e8921e243394b03382c03a6a08054f490c8f3dc8 143
Super Metroid.SMC hash not found 676c6610617d75bf90cea41d1af9f1ac23a36223 299
X Men Arcades Revenge.smc hash not found 168483c973aad51c482ed7e5b052310164ebc7c2 5871

@animedude07
Copy link

Sorry to be that guy, but I found a handful of GBA titles that the scraper wouldn't find. Also, at the bottom of the list, one title that doesn't have a GBD ID, I suspect because it's a ROM rip from a GameCube disc that's been made playable on N64 (The Legend of Zelda: Ocarina of Time Master Quest). Not entirely sure what to do about that, so suggestions are welcome.

https://drive.google.com/file/d/1g6ASmnkAMXmvHW1RN-veo4sizVpofpkL/view?usp=sharing

@Paul-Colucci
Copy link

How do you generate the hashes? Is it MD5 or something? i don't see docs anywhere

@marcalrepoles
Copy link

Need help with the scraper in my Retropie. I saw on another link that I should run the scraper folder by folder and then open the csv file and post here the hash and the ID of my problematic games. But I'm having too many roms with issues on scraper. May I still post the csv file with the hash here or there's something else to try?

The link I've found about the scraper problem is this https://github.com/sselph/scraper/wiki/Scraper-can%27t-find-a-game%3F

@kfbest
Copy link

kfbest commented Oct 28, 2019

Few missing hashes
`

Game Error Hash GamesDB ID
atari2600/Pac-Man.a26 hash not found 9ee09268281dc9d31b761acb32ff5fa866f983aa 36243
atari2600/Adventure.a26 hash not found 4ffe36c5113305714e27c72d7f3abecc9b08a630 2570
nes/Final Fantasy III.nes hash not found b182b75e019afe751e872763f90d81de78f3090d 83
snes/Mega Man X 2.smc hash not found e3160744be80529152247379fb1bdbaa83569c38 1015

`

@OfficePop
Copy link

Some missing SNES hashes.

https://www.dropbox.com/s/2eykaiahp6cdekm/file.csv?dl=0

@marcalrepoles
Copy link

marcalrepoles commented Jan 22, 2020 via email

@ahmedmahm0ud
Copy link

Hey @sselph , Thank u for all of your great work, i hope u can help me with my issue , i have some psx roms with exction .PBP and i can scrap these roms using emulationstation scraper but when i using your script it always tells hash not found ,
Not there are not .bin .cue , because i had use
PSX2PSP to convert them .. i think if we have name search flag it will solve the problem

Sorry for my bad English, and thanks for your great work .

@marcteale
Copy link

With the exception of Micro Mages, all of the games in this list are ROM hacks from romhacking.net. Thanks!

https://www.dropbox.com/s/mhfqyjkeb6cfeeg/file.csv?dl=0

@Wetzel402
Copy link

Wetzel402 commented Oct 14, 2020

Hello @sselph,

I ran your scraper using the fastscraper.bat with screenscraper.fr as the source and had two missing hashes. Interestingly the file did not contain the hash until I downloaded and used your shasum.exe to get the hash and added it manually. The file can be found here.

Thank you for the best scraper on the internet!

Edit: Added some missing Atari Lynx ROMs here.

Edit: Missing GameBoy ROM hashes:
https://github.com/Wetzel402/missing-scraper-hashes/blob/main/_gb_missing.csv

Edit: Missing GBA ROM hashes:
https://github.com/Wetzel402/missing-scraper-hashes/blob/main/_gba_missing.csv

Edit: Missing GameBoy Color ROM hashes:
https://github.com/Wetzel402/missing-scraper-hashes/blob/main/_gbc_missing.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests