Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanName for videos file name, preventing duplicated videos for the same game with different regions / version #186

Merged
merged 5 commits into from
Dec 10, 2017

Conversation

zcstrife
Copy link
Contributor

@zcstrife zcstrife commented Oct 11, 2017

This should prevent duplicated videos for the same game, when several version/regions exist,

Prevent duplicated videos for the same game, when several version/regions exist
@zcstrife zcstrife changed the title PrettyName for videos file name PrettyName for videos file name, preventing duplicated videos for the same game Oct 11, 2017
@zcstrife zcstrife changed the title PrettyName for videos file name, preventing duplicated videos for the same game CleanName for videos file name, preventing duplicated videos for the same game Oct 12, 2017
Missunderstood what PrettyName was standing for
Created CleanName var
@zcstrife zcstrife changed the title CleanName for videos file name, preventing duplicated videos for the same game CleanName for videos file name, preventing duplicated videos for the same game with different regions / version Oct 12, 2017
Strips forbidden characters in filenames
not optimal at all, but it all works fine
@sselph
Copy link
Owner

sselph commented Dec 10, 2017

Sorry for the delay. I'm going to accept this but I think I want to make a few modifications to how it is used. Maybe allow it to be turned off and also to detect the previous name if it exist so that people don't have to download everything again.

@sselph sselph merged commit 012c55b into sselph:master Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants