convert to yuv420p pixel format #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at is expected by the OMX player (hardware accelerated player for raspberry pi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
convertVideofunction's use offfmpegto ensure the pixel format isyuv420p. This is a more common format, and is required by the OMX player. OMX is the hardware accelerated video player that is becoming standard for Retropie.I encountered a need for this with some MAME rom videos.
This may fix #194
Here's a video to try with https://clone.screenscraper.fr/api/mediaVideoJeu.php?devid=sselph&devpassword=ROMHasher20160916&softname=sselph-scraper&crc=&md5=&sha1=&systemeid=158&jeuid=43783&media=video&mediaformat=mp4
Its stream info (reported by ffmpeg) is:
Stream #0:0(und): Video: h264 (High 4:4:4 Predictive) (avc1 / 0x31637661), yuv444p, 224x768 [SAR 18:7 DAR 3:4], 136 kb/s, 29.97 fps, 29.97 tbr, 2997 tbn, 59.94 tbc (default)With this PR the new stream info is:
Stream #0:0(und): Video: h264 (High) (avc1 / 0x31637661), yuv420p, 320x1098 [SAR 1647:640 DAR 3:4], 238 kb/s, 29.97 fps, 29.97 tbr, 11988 tbn, 59.94 tbc (default)