Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow mkdir to work with default attr.st_mode #152

Merged
merged 2 commits into from Oct 13, 2023
Merged

allow mkdir to work with default attr.st_mode #152

merged 2 commits into from Oct 13, 2023

Conversation

mlocutus
Copy link
Contributor

on mkdir, allow defaults instead of blocking on empty attr.st_mode

@mlocutus
fix for ssh-mitm#151
f2a088e 
on mkdir, allow defaults instead of blocking on empty `attr.st_mode`
manfred-kaiser
manfred-kaiser approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@manfred-kaiser manfred-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

@manfred-kaiser
Copy link
Member

the checks failed with following error:

sshmitm/interfaces/sftp.py:63: error: Argument 2 to "mkdir" of "SFTPClient" has 
incompatible type "Optional[int]"; expected "int"  [arg-type]

@manfred-kaiser manfred-kaiser merged commit 6ee0739 into ssh-mitm:master Oct 13, 2023
1 of 5 checks passed
@manfred-kaiser manfred-kaiser mentioned this pull request Oct 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manfred-kaiser manfred-kaiser manfred-kaiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlocutus @manfred-kaiser