Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper sourcehut link #77

Closed
abcdw opened this issue Dec 14, 2020 · 2 comments
Closed

Proper sourcehut link #77

abcdw opened this issue Dec 14, 2020 · 2 comments

Comments

@abcdw
Copy link

abcdw commented Dec 14, 2020

https://github.com/sshaw/git-link/blob/master/git-link.el#L457
For sourcehut (git.sr.ht) used the same function as for github, but it generates a link using https://%s/%s/blob/%s/%s pattern, while for sourcehut it should be https://%s/%s/tree/%s/%s, because /blob/ provides access to raw file, while /tree/ has ability to show exact part of the code using fragment part of address.

As it is right now:
https://git.sr.ht/~abcdw/rde/blob/master/rde/system/install.scm#L50

As it should be:
https://git.sr.ht/~abcdw/rde/tree/master/rde/system/install.scm#L50

@sshaw sshaw closed this as completed in 9a3e893 Dec 14, 2020
@sshaw
Copy link
Owner

sshaw commented Dec 14, 2020

Thanks. I also noticed that multi-line links were broken so fixed that too.

Is the tree URL new or was it always there?

@abcdw
Copy link
Author

abcdw commented Dec 15, 2020

Actually, IDK, use it not so often.

Thank you for fixes!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants