Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library still actively supported? #413

Closed
ghost1face opened this issue Apr 2, 2018 · 11 comments
Closed

Library still actively supported? #413

ghost1face opened this issue Apr 2, 2018 · 11 comments

Comments

@ghost1face
Copy link

Looks like there are a lot of outstanding issues and pull requests. Are there any plans to continue maintaining? Please let me know. I'm sure a few people wouldn't mind jumping in and helping merge and deploy new versions.

@drieseng
Copy link
Member

drieseng commented Apr 2, 2018

Sorry about that. Having a rough and busy period.
I have no plans to abandon SSH.NET.
Which specific PRs do you consider ready for merging?

@znamenap
Copy link

znamenap commented Apr 3, 2018

Hi Gert, I'd like to turn your attention to #396 which has passing build and added unit tests or at least ping a reply of what's wrong with that.

Hi Daniel, Sorry I used your question/issue to promote mine pull request. Waited one day if you or someone else replied, though I found it as the go momentum.

Thank you.
Pavel

@ghost1face
Copy link
Author

You hijacked my issue @znamenap ! haha. No big deal, and I understand @drieseng you are busy. I'll list a few pull requests below. And I personally don't mind helping maintain if you don't mind. It's up to you.

#396 - I haven't pulled it down just looking here but looks good and unit tests are written to support

#361 - Just calls Dispose on IDisposable objects

#360 - Not locking on this instead using a private lock variable for best practices

#388 - Extending authentication modes, think this would need a closer look and an actual test

#356 - Looks good but may want to check .editorconfig standards being placed on the code format

Build breaking but may be good to send back and have them update:

#262 - Good fixes, build breaking
#300 - Support TAP over APM build breaking, on first glance may be helpful to push them to implement in other places if possible

This is just a first glance through the list

@stefer
Copy link

stefer commented Apr 5, 2018

I could also jump in and help where I could. I would be nice to get some of these PR:s through.

@ScottRFrost
Copy link

I haven't been able to update my app to .NET Core 2.x. The only thing holding it back is this library. There doesn't seem to be a tracking issue for it. #337 is the closest issue.

Any idea what's missing before a .NET Core 2.x version can be shipped?

@stefer
Copy link

stefer commented Apr 7, 2018

Therese is a fork for .Net core here: https://github.com/pelhu/SSH.NET.Core

@ScottRFrost
Copy link

Unfortunately, there hasn't been a single commit on that fork in 7 1/2 months, a commit to master in over 2 years, or a release EVER.

@Danzondo
Copy link

Any plans for .net core 2.0 support?
currently the library isnt compatible with recent versions of other libraries

@DanielVukelich
Copy link

Unless I'm misunderstanding something, SSH.NET is already .NET Core 2.0 compatible. It's not in the nuget package, but locally I've produced netstandard 2.0 builds.

@drieseng
Copy link
Member

drieseng commented Jan 22, 2020

I'm doing my best to spend a little more time on SSH.NET.

@niemyjski
Copy link

@drieseng would it be possible to add some contributors to help out? We are finding some small issues downstream (https://github.com/FoundatioFx/Foundatio.Storage.SshNet) and lots of unmerged prs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants