Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #153 support of Task-based Asynchronous Pattern (TAP) over existi… #300

Closed
wants to merge 1 commit into from

Conversation

Bartizan
Copy link

Fix #153 support of Task-based Asynchronous Pattern (TAP) over existing async API for SftpClient. Added into a new project targeting .net 4.5.

What is done. Added a new SshNet project for support await/async and prepared an extensions over SftpClient. Nuget package is still waiting for an update it the change approved.

…existing async API for SftpClient. Added into a new project targeting .net 4.5.
@mmoo9154
Copy link
Contributor

@Bartizan it looks like a number of unneccesary changes to the sln files got checked in with your pull request. You might have better luck if you just commit the changes to src/Renci.SshNet.NET45/SftpClientExtensions.cs which is the significant change.

@Bartizan Bartizan closed this Apr 22, 2020
@Bartizan Bartizan deleted the develop branch April 22, 2020 21:00
@Bartizan
Copy link
Author

@mmoo9154 I see a lot of changes since my PR. I have prepared a new one (#661) according to latest codebase. I had to avoid net35 targeting, maybe it was beyond general convention and it would be better to introduce a definition like FEATURE_SFTPCLIENT_TAP_EXT-something instead of NET35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for a Task based async API
2 participants